Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support service entries in policy rules #1504

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support service entries in policy rules #1504

wants to merge 3 commits into from

Conversation

annakhm
Copy link
Collaborator

@annakhm annakhm commented Jan 15, 2025

This follows API change on NSX that allows to specify explicit service entries on rule, as an alternative to service path.

@annakhm
Support service entries in policy rules
3b2ed51 
This follows API change on NSX that allows to specify
explicit service entries on rule, as an alternative to
service path.

Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
@vmwclabot
Copy link
Member

@annakhm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Jan 15, 2025
@annakhm annakhm linked an issue Jan 17, 2025 that may be closed by this pull request
Possibility to create firewall rules with protocol and port #1135
Open
@vmwclabot
Copy link
Member

@annakhm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@annakhm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@annakhm
Copy link
Collaborator Author

annakhm commented Jan 23, 2025

/test-all

ksamoray
ksamoray approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@ksamoray ksamoray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's rebase this and put order in the commit list to resolve the DCO complaint :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksamoray ksamoray ksamoray approved these changes

@salv-orlando salv-orlando Awaiting requested review from salv-orlando

Assignees
No one assigned
Labels
dco-required DCO Required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possibility to create firewall rules with protocol and port
3 participants
@annakhm @vmwclabot @ksamoray